This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] AndesTech NDS32 port

From: Yan-Ting Lin <currygt52 at gmail dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 6 Jun 2016 23:13:49 +0800
Subject: Re: [PATCH v2] AndesTech NDS32 port
Authentication-results: sourceware.org; auth=none
References: <3561f390-ea41-2ee3-a5a9-d870429497c3 at gmail dot com> <e65af384-a6e2-961d-e270-4decfcdab7c7 at redhat dot com> <ca473d29-ceb4-ba5e-1337-d479a5f16d8b at gmail dot com> <868typxi5r dot fsf at gmail dot com>

> We can either use NDS32_FD0_REGNUM or gdbarch_tdep.fd0_regnum, IMO.  If
> the register number of fd0 is fixed, we can use NDS32_FD0_REGNUM,
> otherwise, we need to use gdbarch_tdep.fd0_regnum.  If so, we can remove
> one of them.
>

Hi Yao,

Thanks for the review.

Currently, the register number of fd0, if present, is always fixed, so
all usage of gdbarch_tdep.fd0_regnum is replaced with
NDS32_FD0_REGNUM.
In addition, after reviewing the flow to initialize gdbarch_tdep, the
allocation and initialization of gdbarch_tdep is put just before the
allocation of gdbarch.

The modified patch is attached, please help to review again.
Thanks a lot.

Attachment: 0001-gdb-new-AndesTech-NDS32-port.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH v2] AndesTech NDS32 port
  - From: Yao Qi
- Re: [PATCH v2] AndesTech NDS32 port
  - From: Pedro Alves

References:
- Re: [PATCH v2] AndesTech NDS32 port
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]