This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix PR python/20129 - use of non-existing variable
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 6 Jun 2016 20:05:07 +0100
- Subject: Re: [RFA] Fix PR python/20129 - use of non-existing variable
- Authentication-results: sourceware.org; auth=none
- References: <1465233765-15675-1-git-send-email-tom at tromey dot com>
On 06/06/16 18:22, Tom Tromey wrote:
> PR python/20129 concerns the error message one gets from a command
> like "disable frame-filter global NoSuchFilter". Currently this
> throws a second, unexpected, exception due to the use of a
> non-existing variable named "name".
>
> This patch adds regression tests and fixes a couple of spots to use
> the correct variable name.
>
> Built and regtested on x86-64 Fedora 23.
>
> 2016-06-06 Tom Tromey <tom@tromey.com>
>
> PR python/20129:
> * python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter)
> (SetFrameFilterPriority._set_filter_priority): Use "frame_filter",
> not "name".
>
> 2016-06-06 Tom Tromey <tom@tromey.com>
>
> PR python/20129:
> * gdb.python/py-framefilter.exp: Add tests for setting priority
> and disabling of non-existent frame filter.
Tom,
It looks fine to me (and the original a buglet anyway).
Cheers
Phil