This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add method/format information to =record-started
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, "Metzger\, Markus T" <markus dot t dot metzger at intel dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 07 Jun 2016 10:32:28 +0100
- Subject: Re: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220 dot 22286-1-simon dot marchi at ericsson dot com> <A78C989F6D9628469189715575E55B23332EAEF5 at IRSMSX104 dot ger dot corp dot intel dot com> <86ziqywju7 dot fsf at gmail dot com> <57557992 dot 90908 at ericsson dot com>
Simon Marchi <simon.marchi@ericsson.com> writes:
> Just to be clear, the inner if/else doesn't need them, but the outer one does.
>
No, it is not "GDB C Coding Standard" compliant, IMO. In the quoted url
I gave,
"Any two or more lines in code should be wrapped in braces, even if they
are comments, as they look like separate statements:"
so...
> Here's the result:
>
>
> if (started)
> {
> if (format != NULL)
brace is needed here...
> fprintf_unfiltered (
> mi->event_channel,
> "record-started,thread-group=\"i%d\",method=\"%s\",format=\"%s\"",
> inferior->num, method, format);
and here
> else
> fprintf_unfiltered (
> mi->event_channel,
> "record-started,thread-group=\"i%d\",method=\"%s\"",
> inferior->num, method);
> }
> else
> fprintf_unfiltered (mi->event_channel,
> "record-stopped,thread-group=\"i%d\"", inferior->num);
--
Yao (éå)