This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] PR python/18565 - make Frame.function work for inline frames
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 21 Jun 2016 09:34:20 +0100
- Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames
- Authentication-results: sourceware.org; auth=none
- References: <1466439050-11330-1-git-send-email-tom at tromey dot com>
Tom Tromey <tom@tromey.com> writes:
> TRY
> {
> + char *funname;
> + enum language funlang;
> +
> FRAPY_REQUIRE_VALID (self, frame);
>
> - sym = find_pc_function (get_frame_address_in_block (frame));
> + find_frame_funname (frame, &funname, &funlang, &sym);
> + xfree (funname);
> }
> CATCH (except, RETURN_MASK_ALL)
> {
Call xfree in CATCH block? Otherwise, patch is good to me.
--
Yao (éå)