This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2][PR gdb/20239] Add tests for printing of NonZero-optimized enums in Rust


>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:

Manish> Continuing discussion from
Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20239, I'm not sure if
Manish> it's worth it to have a test that inspects the entire output, since
Manish> the internals of the String type may change in the future. Did you
Manish> mean something else?

Actually it just wasn't clear to me if the test case in question was "as
complicated" as the code inspiring the original report.  But it probably
doesn't matter.

Manish> gdb/testsuite/ChangeLog:
Manish> 2016-06-21  Manish Goregaokar  <manish@mozilla.com>

Manish>     PR gdb/20239
Manish>     * gdb.rust/simple.rs: Add more tests for printing NonZero enums.
Manish>     * gdb.rust/simple.exp: Add test expectations for new NonZero tests.

Thank you.  This patch is ok.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]