This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2][PR gdb/20239] Add tests for printing of NonZero-optimized enums in Rust
- From: Tom Tromey <tom at tromey dot com>
- To: Manish Goregaokar <manish at mozilla dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Wed, 22 Jun 2016 13:11:31 -0600
- Subject: Re: [PATCH 2/2][PR gdb/20239] Add tests for printing of NonZero-optimized enums in Rust
- Authentication-results: sourceware.org; auth=none
- References: <CAFOnWkmnZbnZ0VV6tiOOz+8rxCDokx0cTv8ojZ1Q6mCxGLrfCQ at mail dot gmail dot com>
>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:
Manish> Continuing discussion from
Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20239, I'm not sure if
Manish> it's worth it to have a test that inspects the entire output, since
Manish> the internals of the String type may change in the future. Did you
Manish> mean something else?
Actually it just wasn't clear to me if the test case in question was "as
complicated" as the code inspiring the original report. But it probably
doesn't matter.
Manish> gdb/testsuite/ChangeLog:
Manish> 2016-06-21 Manish Goregaokar <manish@mozilla.com>
Manish> PR gdb/20239
Manish> * gdb.rust/simple.rs: Add more tests for printing NonZero enums.
Manish> * gdb.rust/simple.exp: Add test expectations for new NonZero tests.
Thank you. This patch is ok.
Tom