This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4] Tweak catch syscall for remote
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 23 Jun 2016 16:10:56 +0100
- Subject: Re: [PATCH 0/4] Tweak catch syscall for remote
- Authentication-results: sourceware.org; auth=none
- References: <1466158585-21833-1-git-send-email-yao dot qi at linaro dot org>
On 06/17/2016 11:16 AM, Yao Qi wrote:
> I see some test fails in catch-syscall.exp on aarch64 with
> native-gdbserver. This patch series add catch syscall in remote for
> both aarch64-linux and arm-linux.
>
> Currently, only catch syscall for remote is only supported on x86, but
> the test is run on other targets. Patch 1 fixes the issue in
> catch-sysca.exp about probing the catch syscall support.
>
> Patch 2 removes one redundant parameter in
> linux_target_ops.get_syscall_trapinfo. Patch 3 and 4 adds support for
> aarch64-linux and arm-linux respectively.
>
LGTM. Might want to handle read_memory failing in patch 4, as it
leaves "insn" undefined if that happens.
Thanks,
Pedro Alves