This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/3] Clear frame cache when loading or unloading a JIT unwinder
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 23 Jun 2016 20:39:45 -0600
- Subject: Re: [RFA 1/3] Clear frame cache when loading or unloading a JIT unwinder
- Authentication-results: sourceware.org; auth=none
- References: <1465612923-24880-1-git-send-email-tom at tromey dot com> <1465612923-24880-2-git-send-email-tom at tromey dot com> <525d6968-595b-b4cf-f16e-83ac08f5559f at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Tom> jit-reader-load apparently has no tests in-tree, so I didn't add a new
Tom> test here.
Pedro> Yeah. Tests existed, but had never been pushed in the tree... I fixed
Pedro> that now:
Pedro> https://sourceware.org/ml/gdb-patches/2016-06/msg00308.html
Pedro> Could you see if it's easy to extend the test to cover this?
I looked and I didn't see a straightforward way.
The basic problem is that flushing the frame cache doesn't affect the
results in the jit-reader.exp test. In this test, the test case can be
unwound without assistance; JIT reader in question supplies some
symbols. Clearing the frame cache doesn't affect this.
FWIW I don't care all that much about this patch. It seemed like an
oversight to me, but I'm more concerned with getting the Python case
right, since in the end that's the sort of unwinder I wrote.
Tom