This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
- From: Manish Goregaokar <manish at mozilla dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Wed, 29 Jun 2016 14:27:56 +0530
- Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
- Authentication-results: sourceware.org; auth=none
- References: <CAFOnWkngUQXjGd27gkBnh+3697TUMGk4zcp5uY+MmJXsYusDGw at mail dot gmail dot com> <5013369 dot B1hQpEVniv at e108577-lin>
No, strsep was just a better fit here. I wasn't aware that it doesn't
work on windows.
I'll fix it to use strtok.
-Manish
On Wed, Jun 29, 2016 at 2:25 PM, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> Hi Manish,
>
> On Saturday 25 June 2016 11:30:39 Manish Goregaokar wrote:
>> After further fixups, these patches have been pushed as
>> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=b5a4b3c5
>> e711be9096423f9765623eda449d8f4d and
>> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=fccb08f
>> 8cd2035b50a2b0a5e09983180b7411685
>
> GDB fails to build on Windows (mingw build) due to this patch as strsep is not
> available. Was there something preventing the use of strtok?
>
> Best regards,
>
> Thomas