This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Manish Goregaokar <manish at mozilla dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Wed, 29 Jun 2016 10:15:21 +0100
- Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
- Authentication-results: sourceware.org; auth=none
- References: <CAFOnWkngUQXjGd27gkBnh+3697TUMGk4zcp5uY+MmJXsYusDGw at mail dot gmail dot com> <5013369 dot B1hQpEVniv at e108577-lin> <CAFOnWk=c4PxeagbKO3z2i4uMUPfb_-FVbFh0B4QZMC1aoMUWZA at mail dot gmail dot com>
On Wednesday 29 June 2016 14:27:56 Manish Goregaokar wrote:
> No, strsep was just a better fit here. I wasn't aware that it doesn't
> work on windows.
I just found it when investigating the build failure: the manual says it
conforms to 4.4BSD and suggest the use of strtok for portability.
>
> I'll fix it to use strtok.
Great, many thanks! While you are at it, shouldn't an include of string.h be
added as well? It clearly does not fail now without it because I suppose
another header is including it.
Best regards,
Thomas