This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/6] Use ATTRIBUTE_UNUSED in some places
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 Jun 2016 10:50:41 +0100
- Subject: Re: [RFA 2/6] Use ATTRIBUTE_UNUSED in some places
- Authentication-results: sourceware.org; auth=none
- References: <1465248812-23902-1-git-send-email-tom at tromey dot com> <1465248812-23902-3-git-send-email-tom at tromey dot com> <4e0f2f7a-6363-271d-2d91-4f8352d6509f at redhat dot com> <87shvxt4i0 dot fsf at tromey dot com>
On 06/28/2016 09:58 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I think we should use getcurx/getcury instead.
>
> I've split the patch into two.
>
> The inflow bits remain the same as what was posted. I can repost this
> if you want.
No need.
>
> This new patch replaces the uses of getyx with getcurx.
>
> Tom
>
> commit 2caa6df91fe83630faa615011a724748feee7a30
> Author: Tom Tromey <tom@tromey.com>
> Date: Tue Jun 28 14:25:49 2016 -0600
>
> Use getcurx in curses code
>
> As suggested by Pedro, this changes a few spots to use getcurx, rather
> than getyx. This avoids some unused variable warnings.
>
> 2016-06-28 Tom Tromey <tom@tromey.com>
>
> * tui/tui-winsource.c (tui_show_source_line): Use getcurx.
> * tui/tui-io.c (tui_puts): Use getcurx.
> (tui_redisplay_readline): Likewise.
>
OK.
Thanks,
Pedro Alves