This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH V2 1/1] Fix of default lookup for "this" symbol.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "palves at redhat dot com" <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 1 Jul 2016 11:38:12 +0000
- Subject: RE: [PATCH V2 1/1] Fix of default lookup for "this" symbol.
- Authentication-results: sourceware.org; auth=none
- References: <1467118304-31635-1-git-send-email-walfred dot tedeschi at intel dot com> <86eg7dzmm4 dot fsf at gmail dot com>
Yao,
Thanks for your review!
Yes I run all test suites. I was afraid that we could break other languages as weel.
However it was only 64bit tests, but all suites.
I will rewrite the entry for the Changelog. May I push then, or do you want to review it again?
Thanks and regards,
/Fred
PS: Sorry for top posting, I have to reconfigure my thunderbird.
-----Original Message-----
From: Yao Qi [mailto:qiyaoltc@gmail.com]
Sent: Friday, July 1, 2016 11:20 AM
To: Tedeschi, Walfred <walfred.tedeschi@intel.com>
Cc: palves@redhat.com; qiyaoltc@gmail.com; gdb-patches@sourceware.org
Subject: Re: [PATCH V2 1/1] Fix of default lookup for "this" symbol.
Walfred Tedeschi <walfred.tedeschi@intel.com> writes:
> Tests: Performed tests with gfortran and ifort.
>
I assume you run all gdb testsuite rather than fortran tests only.
The patch is good to me if it is regression free with running all gdb tests.
> 2016-06-16 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/ChangeLog:
>
> * cp-namespace.c (cp_lookup_bare_symbol): Add check for the
> name_of_this in order to return a null symbol when looking up
> for "this".
The entry doesn't reflect your change below. Please rewrite it.
--
Yao (éå)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928