This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow subscripting raw pointers


I am using git format-patch and pasting it into GMail text mode. Probably should set up mutt; haven't yet because I was behind a port-blocked university connection for years :)

I'll see what I can do.

Tom Tromey wrote:
> Manish> 2016-07-04  Manish Goregaokar  <manish@mozilla.com>
> Manish> gdb/ChangeLog:
> Manish>     * rust-lang.c (rust_subscript): Allow subscripting pointers
> Manish> gdb/testsuite/ChangeLog:
> Manish>     * simple.rs: Add test for raw pointer subscripting
> Manish>     * simple.exp: Add test expectations
>
> This is ok.  Thanks.
>
> Manish> +      else if (TYPE_CODE (type) == TYPE_CODE_PTR)
> Manish> +    {
> Manish> +      base = lhs;
> Manish> +      low_bound = 0;
> Manish> +      high_bound = LONGEST_MAX;
> Manish> +    }
> Manish>        else
>
> I suspect maybe your MUA is misconfigured somehow?  Your patches often
> come out looking like the indentation is messed up; but in this case the
> context makes it clear that the indentation is probably ok.
>
> Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]