This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Allow subscripting raw pointers
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Manish Goregaokar <manish at mozilla dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Tue, 5 Jul 2016 13:47:10 -0400
- Subject: Re: [PATCH] Allow subscripting raw pointers
- Authentication-results: sourceware.org; auth=none
- References: <CAFOnWknrO_Gtgj+k_foXMJk3UkzRtdq7WgzENZ4cPf2bRUv8RA@mail.gmail.com> <87r3b8gfyd.fsf@tromey.com> <1467739954112.ab2ed64e1ba@mozgaia>
On Tue, Jul 05, 2016 at 10:32:38AM -0700, Manish Goregaokar wrote:
> I am using git format-patch and pasting it into GMail text mode. Probably should set up mutt; haven't yet because I was behind a port-blocked university connection for years :)
fwiw while people usually block 25 I don't think I've ever seen someone
block 587.
> I'll see what I can do.
you might want to try git send-email if your going to make gmail handle
outbound smtp for you already.
Trev
>
> Tom Tromey wrote:
> > Manish> 2016-07-04 Manish Goregaokar <manish@mozilla.com>
> > Manish> gdb/ChangeLog:
> > Manish> * rust-lang.c (rust_subscript): Allow subscripting pointers
> > Manish> gdb/testsuite/ChangeLog:
> > Manish> * simple.rs: Add test for raw pointer subscripting
> > Manish> * simple.exp: Add test expectations
> >
> > This is ok. Thanks.
> >
> > Manish> + else if (TYPE_CODE (type) == TYPE_CODE_PTR)
> > Manish> + {
> > Manish> + base = lhs;
> > Manish> + low_bound = 0;
> > Manish> + high_bound = LONGEST_MAX;
> > Manish> + }
> > Manish> else
> >
> > I suspect maybe your MUA is misconfigured somehow? Your patches often
> > come out looking like the indentation is messed up; but in this case the
> > context makes it clear that the indentation is probably ok.
> >
> > Tom