This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable


>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:

Yao> On Thu, Jul 21, 2016 at 4:18 PM, Pedro Alves <palves@redhat.com> wrote:
>> No build regressions on
>> 
>> PPC64 GNU/Linux
>> S390 GNU/Linux
>> x64-64 NetBSD
>> 
>> Any host missing?  I think we're good to go.
>> 

Yao> I don't think of any.  Yes, please :)

I'll push the patch in momentarily.  Feel free to ping me on any build
problems.  I can't test them but I am happy to write a patch for someone
else to try.


There are a few more warnings that would be good to enable.

-Wmisleading-indentation (for me gdb is already clean here)

-Wduplicated-cond
-Wtautological-compare

I have a patch for a couple of problems pointed out by this, but there
is a larger one, https://sourceware.org/bugzilla/show_bug.cgi?id=20362
- a pretty big bug in arm_record_vfp_data_proc_insn.

It would be handy to have a "try" server on the buildbot to test patches
like this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]