Re: [PATCH] Fix exception unwinding for ARM Cortex-M

["Fredrik Hederstierna" <fredrik dot hederstierna at verisure dot com>]

-----Yao Qi <qiyaoltc@gmail.com> wrote: -----
>Fredrik,
>A general comment to this patch is that you need to split it. Each
>patch only addresses one issue or adds one support.

Ok, I send you first patch, this one fix EXC_RETURN values.

>We need to consider ARMv6-M as well,
>> + switch (pc)
>> + {
>> + /* From Table B1-8 and B1-9 the EXC_RETURN definition of
>> + the exception return behavior. */
>> +
>> + /* Return to Handler mode. Return stack Main. Frame type
>Extended. */
>
>I don't see anything useful the comment has. We can remove it.
>Instead, we need to document, on ARMv6-M and ARMv7-M without FP
>extension, the exc_return is 0xfffffff{1,9,d}. On ARMv7-M with FP
>extension, exc_return can be 0xffffff{e,f}{1,9,d}.

Ok, I documented also ARMv6-M in new patch.

>Please post the patch only for magic pc handling, then I can review
>and approve it.

Ok, done. Attached first patch.
I will submit next when it is ready.

Thanks & Kind Regards,
Fredrik

Attachment: gdb-cortex-m-exc-return-values.patch
Description: Binary data