This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping] [PATCH v2 0/6] fortran: multi-dimensional subarrays with strides


Hello Christoph,

0001-fortran-allow-multi-dimensional-subarrays.patch
contains:
+  elt_size = TYPE_LENGTH (elt_type);
+  elt_offs = longest_to_int (lowbound - ary_low_bound);
+  elt_stride = TYPE_LENGTH (TYPE_INDEX_TYPE (array_type));
+         
+  elt_offs *= elt_size;

which now causes:
valops.c:3803:11: error: variable ‘elt_stride’ set but not used [-Werror=unused-but-set-variable]
   LONGEST elt_stride, ary_high_bound, ary_low_bound;
           ^~~~~~~~~~

but other patches contained:

+  if (elt_stride > 0)
+    elt_offs *= elt_stride;
[...]
+  else
+    elt_offs *= elt_size;

This may explain some Fortran testcase stride failure I was seeing and
bugreporting to you off-list.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]