This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile}

From: Yao Qi <qiyaoltc at gmail dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Tue, 23 Aug 2016 14:28:36 +0100
Subject: Re: [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile}
Authentication-results: sourceware.org; auth=none
References: <1471877845-1158-1-git-send-email-yao.qi@linaro.org> <ba1f883876e7703b732d64d522d61bde@simark.ca>

On Mon, Aug 22, 2016 at 7:12 PM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> On 2016-08-22 10:57, Yao Qi wrote:
>>
>> --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp
>> +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp
>> @@ -44,7 +44,7 @@ proc do_test {nonstop} {
>>
>>      gdb_test "set non-stop $nonstop"
>>
>> -    set res [gdbserver_spawn ${binfile}]
>> +    set res [gdbserver_spawn ""]
>
>
> You could make gdbserver_spawn have a default empty argument, so you don't
> have to keep the empty string here.

Yes, this can be a separate fix.  I don't have cycles to fix it
recently, so patch
is welcome :)

-- 
Yao (齐尧)

References:
- [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile}
  - From: Yao Qi
- Re: [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile}
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]