This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [GDBserver] Replace "reinsert_breakpoint" with "singlestep_breakpoint"
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 1 Sep 2016 17:18:32 +0100
- Subject: Re: [PATCH] [GDBserver] Replace "reinsert_breakpoint" with "singlestep_breakpoint"
- Authentication-results: sourceware.org; auth=none
- References: <1472720480-4651-1-git-send-email-yao.qi@linaro.org>
On 09/01/2016 10:01 AM, Yao Qi wrote:
> reinsert_breakpoint is used for software single step, so it is more
> clear to rename it to singleste_breakpoint. This was pointed out in
> the review https://sourceware.org/ml/gdb-patches/2016-05/msg00429.html
> I don't rename "other_breakpoint" in this patch.
Thanks!
> 2016-09-01 Yao Qi <yao.qi@linaro.org>
>
> * linux-low.c: Replace "reinsert_breakpoints" with
> "singlestep_breakpoints". Replace "reinsert breakpoints"
> with "singlestep breakpoints".
> * mem-break.c: Likewise.
> * mem-break.h: Likewise.
I hate to be this picky, but I have to say that it itches me that both
gdb and gdbserver currently largely use "single-step" instead of "singlestep"
in comments and largely uses "single_step" instead of "singlestep" in
function signatures:
$ cd gdb
$ grep -rn "single-step" --exclude='ChangeLog*' --exclude="gdbarch.c" --exclude="gdbarch.h" | wc -l
371
$ grep -rn "single_step" --exclude='ChangeLog*' --exclude="gdbarch.c" --exclude="gdbarch.h" | wc -l
276
$ grep -rn "singlestep" --exclude='ChangeLog*' --exclude="gdbarch.c" --exclude="gdbarch.h" | wc -l
37
Did you consider following this scheme?
Pedro Alves