This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Set process affinity in test to work around ARM ptrace bug
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 2 Sep 2016 02:00:37 +0100
- Subject: Re: [RFC] Set process affinity in test to work around ARM ptrace bug
- Authentication-results: sourceware.org; auth=none
- References: <1467295036-2816-1-git-send-email-yao.qi@linaro.org> <af0b4e20-faba-8c51-4d98-3bbbd5899f39@redhat.com> <86a8hxzni8.fsf@gmail.com> <CAH=s-PMBzfgkio6mDtB5MkTFpGTmEU_7A0qCGe_CzyfMSDYKBw@mail.gmail.com> <eec0d5c5-2100-6579-1dbc-2ad8fe5d11f9@redhat.com> <86vayfbrrf.fsf@gmail.com>
On 09/01/2016 03:48 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> But since this is only for when running the testsuite alone, I could argue that
>> this masks the problem and thus makes it look like gdb works better on an
>> affected system than it really does. I think if I were working on gdb/gdbserver
>> on arm, I'd much prefer if gdb told me my system had a broken ptrace, so I
>> could act on it, rather than masking it off and pretend all is well.
>> How about we make gdb / gdbserver detect bad kernel version, and output a
>> warning to the effect? We already have precedent in
>> nat/linux-ptrace.c.
>
> Do you mean linux_ptrace_test_ret_to_nx_instr?
Yes.
>
>> I think we should probably do that regardless of any testsuite workaround.
>>
>
> Yes, I agree. I'll write a test in nat/linux-ptrace.c too.
>
> I happen to see there is a proc gdb_skip_float_test, so I write a patch
> to detect broken kernel ptrace in it, and use gdb_skip_float_test all
> over the test cases. How about the patch below?
I like it. This version LGTM. Thanks for adjusting.
--
Pedro Alves