This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
- From: Manish Goregaokar <manish at mozilla dot com>
- To: Akash Trehan <akash dot trehan123 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 2 Sep 2016 22:21:35 +0530
- Subject: Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
- Authentication-results: sourceware.org; auth=none
- References: <CA+MaScmksSaZVtpeHP6McrPG_yiJWKJe_EXyHSON_FPpsCh5uA@mail.gmail.com>
Reformatted patch below. Please ensure that the diff is one which
can be imported via `git apply`
2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
gdb/gdbserver/ChangeLog:
PR gdb/19495
* remote-utils.c (relocate_instruction): Remove redundant strcpy()
call writing data to own_buf.
---
gdb/gdbserver/remote-utils.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 768d2e9..1d51010 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
ULONGEST written = 0;
/* Send the request. */
- strcpy (own_buf, "qRelocInsn:");
sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
paddress (*to));
if (putpkt (own_buf) < 0)
--
2.8.3
Thanks,
-Manish
-Manish
On Fri, Sep 2, 2016 at 9:10 PM, Akash Trehan <akash.trehan123@gmail.com> wrote:
> The tests successfully ran after the patch.
> Also I've requested for copyright assignment. I'm not sure if I really
> need it for this patch, do I?
>
>
> 2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
>
>
> gdb/gdbserver/ChangeLog:
>
> PR gdb/19495
>
> * remote-utils.c (relocate_instruction): Remove redundant strcpy()
>
> call writing data to own_buf.
>
> ---
>
> gdb/gdbserver/remote-utils.c | 1 -
>
> 1 file changed, 1 deletion(-)
>
>
>
>
> diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
>
> index 768d2e9..1d51010 100644
>
> --- a/gdb/gdbserver/remote-utils.c
>
> +++ b/gdb/gdbserver/remote-utils.c
>
> @@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
>
> ULONGEST written = 0;
>
>
>
> /* Send the request. */
>
> - strcpy (own_buf, "qRelocInsn:");
>
> sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
>
> paddress (*to));
>
> if (putpkt (own_buf) < 0)