This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: palves at redhat dot com (Pedro Alves)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 19 Sep 2016 18:18:24 +0200 (CEST)
- Subject: Re: [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls
- Authentication-results: sourceware.org; auth=none
> On 09/19/2016 04:23 PM, Pedro Alves wrote:
> > On 09/19/2016 03:56 PM, Ulrich Weigand wrote:
> >> Pedro Alves wrote:
> >>
> >>> I tried a --disable-nls with both gcc 5.1 and 4.7 here, and it
> >>> doesn't trigger this. I can't seem to find the libintl.h inclusion
> >>> you're seeing. Sounds like that was changed at some point.
> >>
> >> Yes, it looks like these days the C++ headers include a lot fewer
> >> of the base C headers (fixing namespace pollution, maybe?).
> >
> > Yeah, I assume so.
> >
> >>> Alternatively, simply remove the troublesome *gettext and *textdomain
> >>> macros, leaving only the _ and N_ ones. I can't seem to find any
> >>> directly reference to gettext in the tree. The textdomain calls
> >>> in main.c would need to be wrapped in #ifdef ENABLE_NLS, but
> >>> likes like that is all.
> >>
> >> This would also work, and seems the cleanest solution.
> >
> > OK, I'm testing a patch.
>
> I've pushed this in now.
Thanks, Pedro!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com