This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 07/22] Change scoped_minimal_symbol_reader to store objfile


>       Currently, minimal symbol table creation is not reentrant; it
>       relies on global (static) variables in minsyms.c.  */
>  
> -  explicit scoped_minimal_symbol_reader ();
> +  explicit scoped_minimal_symbol_reader (struct objfile *);

C++ doesn't require the explicit struct / union  when refering to the
type, though of course you can keep them if you think it makes something
clearer.

> @@ -79,6 +79,8 @@ class scoped_minimal_symbol_reader
>    scoped_minimal_symbol_reader &operator=
>      (const scoped_minimal_symbol_reader &);
>    scoped_minimal_symbol_reader (const scoped_minimal_symbol_reader &);
> +
> +  struct objfile *objfile;

fwiw gcc convention is to prefix members with m_, so doing so in gdb as
well would be nice.

Trev


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]