This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [committed] testsuite: solib-disc: Use `standard_output_file'
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 06 Oct 2016 11:01:32 -0400
- Subject: Re: [committed] testsuite: solib-disc: Use `standard_output_file'
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.00.1610061506120.31859@tp.orcam.me.uk>
On 2016-10-06 10:17, Maciej W. Rozycki wrote:
Correct a commit 2151ccc56c74 ("Always organize test artifacts in a
directory hierarchy") regression causing:
Running .../gdb/testsuite/gdb.base/solib-disc.exp ...
gdb compile failed, Assembler messages:
Fatal error: can't create .../gdb/testsuite/gdb.base/so-disc-shr.c.o:
No such file or directory
by using `standard_output_file' to construct output file names
throughout.
gdb/testsuite/
* gdb.base/solib-disc.exp: Use `standard_output_file'
throughout.
---
Tested with `mips-mti-linux-gnu':
Running .../gdb/testsuite/gdb.base/solib-disc.exp ...
PASS: gdb.base/solib-disc.exp: set stop-on-solib-events 1
PASS: gdb.base/solib-disc.exp: continue to load
PASS: gdb.base/solib-disc.exp: save $pc after load
PASS: gdb.base/solib-disc.exp: disconnect after load
PASS: gdb.base/solib-disc.exp: reconnect after load
PASS: gdb.base/solib-disc.exp: check $pc after load
PASS: gdb.base/solib-disc.exp: continue to unload
PASS: gdb.base/solib-disc.exp: save $pc after unload
PASS: gdb.base/solib-disc.exp: disconnect after unload
PASS: gdb.base/solib-disc.exp: reconnect after unload
PASS: gdb.base/solib-disc.exp: check $pc after unload
and committed as obvious.
Maciej
Good catch! I probably hadn't tested the patch with gdbserver...
Did you consider using standard_testfile to define the usual testfile,
srcfile and binfile?