This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] PR mi/20395 - Fix -var-update for registers in frames 1 and up


* Don Breazeal <donb@codesourcery.com> [2016-10-04 13:56:37 -0700]:

> +
> +	    # Check that the addresses are the same.
> +	    if {[expr $bpaddr != $pcval]} then {
> +	        fail "\$pc does not equal address of breakpoint"
> +	    } else {
> +	        pass "\$pc equals address of breakpoint"

This PASS is repeated multiple times and is not unique, which I think
test names are supposed to be.

Otherwise it looks fine to me, though I'm not a maintainer, so can't
approve the patch :)

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]