This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] PR mi/20395 - Fix -var-update for registers in frames 1 and up
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Don Breazeal <donb at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, palves at redhat dot com
- Date: Fri, 7 Oct 2016 01:05:20 +0100
- Subject: Re: [PATCH v3] PR mi/20395 - Fix -var-update for registers in frames 1 and up
- Authentication-results: sourceware.org; auth=none
- References: <5e305a9a-5582-a2e9-240d-48845ac903d6@redhat.com> <1475614597-109500-1-git-send-email-donb@codesourcery.com>
* Don Breazeal <donb@codesourcery.com> [2016-10-04 13:56:37 -0700]:
> +
> + # Check that the addresses are the same.
> + if {[expr $bpaddr != $pcval]} then {
> + fail "\$pc does not equal address of breakpoint"
> + } else {
> + pass "\$pc equals address of breakpoint"
This PASS is repeated multiple times and is not unique, which I think
test names are supposed to be.
Otherwise it looks fine to me, though I'm not a maintainer, so can't
approve the patch :)
Thanks,
Andrew