This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2 12/17] Remove make_cleanup_restore_current_uiout


On 10/13/2016 10:10 PM, Tom Tromey wrote:

> -  print_stop_location (&last);
> +  {
> +    scoped_restore save_uiout = make_scoped_restore (&current_uiout);
> +    current_uiout = uiout;

I wonder if you had a reasoning that led to deciding when
to use two-argument form?  A couple places looked like obvious
candidates.  My reasoning would be: if the assignment is right
after the scoped_restore creation.

Anyway, this is OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]