This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 02/17] Use scoped_restore for ui_file

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 14 Oct 2016 15:33:05 -0600
Subject: Re: [RFA v2 02/17] Use scoped_restore for ui_file
Authentication-results: sourceware.org; auth=none
References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-3-git-send-email-tom@tromey.com> <88d4c1e5-170d-a981-ba8b-484b447613e6@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I wonder if aligning like:
Pedro>      scoped_restore save_stdout
Pedro>        = make_scoped_restore (&gdb_stdout, str_file);
Pedro>      scoped_restore save_stderr
Pedro>        = make_scoped_restore (&gdb_stderr, str_file);
Pedro>      scoped_restore save_stdlog
Pedro>        = make_scoped_restore (&gdb_stdlog, str_file);
Pedro>      scoped_restore save_stdtarg
Pedro>        = make_scoped_restore (&gdb_stdtarg, str_file);
Pedro>      scoped_restore save_stdtargerr
Pedro>        = make_scoped_restore (&gdb_stdtargerr, str_file);
Pedro> would read better.  Can't tell on the mail client.
Pedro> Up to you; just a thought.

I think so.  I went ahead and made this change.

Tom

References:
- [RFA v2 00/17] more C++
  - From: Tom Tromey
- [RFA v2 02/17] Use scoped_restore for ui_file
  - From: Tom Tromey
- Re: [RFA v2 02/17] Use scoped_restore for ui_file
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]