Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual

[Pedro Alves <palves at redhat dot com>]

On 10/25/2016 02:47 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall
> Pedro> at some point.
> 
> Perhaps it's worth adding it explicitly in configure.ac.
> (Though I don't know why it was removed from -Wall, so maybe it's not
> always appropriate, for reasons I don't know.)

Yeah, cross my mind too.  I'd like to understand why it was
removed first.  (I don't know whether it used to be in -Wall, or
default, or enabled along some other -Wfoo option.)

I found these:

 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302
 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=15214

but those fixed false positives.  I think that would
have supported enabling by default.  Sounds like something
else might have been identified.

Thanks,
Pedro Alves