This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 6/7] python: Add tests for record Python bindings

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: "Wiederhake, Tim" <tim dot wiederhake at intel dot com>
Cc: gdb-patches at sourceware dot org, palves at redhat dot com, "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
Date: Fri, 28 Oct 2016 13:47:10 -0400
Subject: Re: [PATCH 6/7] python: Add tests for record Python bindings
Authentication-results: sourceware.org; auth=none
References: <1477549711-2603-1-git-send-email-tim.wiederhake@intel.com> <1477549711-2603-7-git-send-email-tim.wiederhake@intel.com> <a14406cc50e97665c450bf04219f85be@polymtl.ca> <9676A094AF46E14E8265E7A3F4CCE9AF90C979@irsmsx105.ger.corp.intel.com>

On 2016-10-28 09:48, Wiederhake, Tim wrote:

If you are recording using the "full" method and try to access the
data from Python, you get a not-yet-implemented exception. All we can
test in this case is that the recording method in the gdb.Record
object is displayed properly, i.e. gdb.current_recording().method ==
"full". I could rename py-record.exp to py-record-btrace.exp and add a
py-record-full.exp with that exact test in it, but I don't see too
much value in that. Your opinion?

I think that at least renaming it to py-record-btrace.exp as yousuggested would be good, since it tests specifically btrace. That willleave room for an eventual py-record.exp including more generic tests.

References:
- [PATCH 0/7] Python bindings for btrace recordings
  - From: Tim Wiederhake
- [PATCH 6/7] python: Add tests for record Python bindings
  - From: Tim Wiederhake
- Re: [PATCH 6/7] python: Add tests for record Python bindings
  - From: Simon Marchi
- RE: [PATCH 6/7] python: Add tests for record Python bindings
  - From: Wiederhake, Tim

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]