Re: [PATCH] Fix PR breakpoints/20739: Badly formatted adress string in error message

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2016-10-29 14:39, Cordian A. Daniluk wrote:
> Remove duplicate `0x'-prefix for the hex address printed. `paddress'
> already prepends this, so no need to do it manually.
>
> gdb/ChangeLog:
>
> 	* breakpoint.c (check_fast_tracepoint_sals): fix PR
> 	breakpoints/20739
> ---
>  gdb/breakpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 25849da..0adebae 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -9628,7 +9628,7 @@ check_fast_tracepoint_sals (struct gdbarch 
> *gdbarch,
>        old_chain = make_cleanup (xfree, msg);
>
>        if (!rslt)
> -	error (_("May not have a fast tracepoint at 0x%s%s"),
> +	error (_("May not have a fast tracepoint at %s%s"),
>  	       paddress (sarch, sal->pc), (msg ? msg : ""));
>
>        do_cleanups (old_chain);

That seems like an obvious fix to me, thanks for addressing it.

For the ChangeLog entry, you should follow the standard format as 
described in the following link:

https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

That means to put the PR mention above the list of files.  The 
description should tell more or less precisely _what_ has changed (and 
not _why_ it was changed, that belongs to the commit message, which is 
already clear in your case).

For example:

	PR breakpoints/20739
	* breakpoint.c (check_fast_tracepoint_sals): Don't print duplicate 0x
	prefix.

I don't see your name in MAINTAINERS, do you have write access to the 
repo?  If you plan to contribute patches regularly, it would be a good 
idea for you to go through the process to get it (you'll need assistance 
from one of the global maintainers).  Otherwise, somebody else with 
write access can push it for you.

Thanks,

Simon