This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] agent_expr_up: gdb::unique_ptr -> std::unique_ptr
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 9 Nov 2016 12:24:23 +0000
- Subject: Re: [PATCH] agent_expr_up: gdb::unique_ptr -> std::unique_ptr
- Authentication-results: sourceware.org; auth=none
- References: <1478652972-11094-1-git-send-email-palves@redhat.com>
On Wed, Nov 9, 2016 at 12:56 AM, Pedro Alves <palves@redhat.com> wrote:
>
> - /* Vector owns pointers. */
> - std::vector<agent_expr *> m_aexprs;
> + std::vector<std::unique_ptr<agent_expr>> m_aexprs;
Nit: s/std::unique_ptr<agent_expr>/agent_expr_up/ ?
The patch is good to me.
[Pretend having some C++ 11 knowledge after reading some pages
in "C++ Primer, fifth edition" for 20 minutes]
--
Yao (齐尧)