This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 08/11] Remove ensure_python_env
LGTM. A comment on a comment, below.
On 11/12/2016 09:28 PM, Tom Tromey wrote:
> -/* Called before entering the Python interpreter to install the
> - current language and architecture to be used for Python values.
> - Also set the active extension language for GDB so that SIGINT's
> - are directed our way, and if necessary install the right SIGINT
> - handler. */
Does gdbpy_enter's description have an equivalent comment, or would we
lose some detail that would better be moved? I haven't gone back and
checked your original patch.
> -struct cleanup *
> -ensure_python_env (struct gdbarch *gdbarch,
> - const struct language_defn *language)
Thanks,
Pedro Alves