This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 07/23] Fix spelling mistakes in comments in shell scripts


On 11/20/2016 05:38 PM, Ambrogino Modigliani wrote:
> gdb/ChangeLog:
> 
>         * gdb/contrib/expect-read1.sh: Fix spelling in comments.
>         * gdb/gdb_buildall.sh: Fix spelling in comments.
>         * gdb/gdb_mbuildw.sh: Fix spelling in comments.

Typo "gdb_mbuildw.sh" -> "gdb_mbuild.sh".  :-)

> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb/testsuite/dg-extract-results.sh: Fix spelling in comments.

This file is a copy of gcc's contrib/dg-extract-results.sh.  Could you 
send the fix there?

> 
> ld/ChangeLog:
> 
>         * ld/emulparams/elf32mcore.sh: Fix spelling in comments.

ld changes should go the the binutils list.  See the top level
MAINTAINERS file.

> -# This tool excercise any incomplete reads handling in the testsuite by
> +# This tool exercise any incomplete reads handling in the testsuite by

"This tool exercises".

I pushed this fixed patch below.

>From ca3cbe5cd7715d1559d55f8e71be1dd7340f13b1 Mon Sep 17 00:00:00 2001
From: Ambrogino Modigliani <ambrogino.modigliani@gmail.com>
Date: Tue, 22 Nov 2016 16:05:00 +0000
Subject: [PATCH] Fix spelling mistakes in comments in shell scripts

gdb/ChangeLog:
2016-11-22  Ambrogino Modigliani  <ambrogino.modigliani@gmail.com>

        * contrib/expect-read1.sh: Fix spelling in comments.
        * gdb_buildall.sh: Fix spelling in comments.
        * gdb_mbuild.sh: Fix spelling in comments.
---
 gdb/ChangeLog               | 6 ++++++
 gdb/contrib/expect-read1.sh | 2 +-
 gdb/gdb_buildall.sh         | 2 +-
 gdb/gdb_mbuild.sh           | 4 ++--
 4 files changed, 10 insertions(+), 4 deletions(-)
 mode change 100644 => 100755 gdb/contrib/expect-read1.sh

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3257bae..2849067 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2016-11-22  Ambrogino Modigliani  <ambrogino.modigliani@gmail.com>
 
+        * contrib/expect-read1.sh: Fix spelling in comments.
+        * gdb_buildall.sh: Fix spelling in comments.
+        * gdb_mbuild.sh: Fix spelling in comments.
+
+2016-11-22  Ambrogino Modigliani  <ambrogino.modigliani@gmail.com>
+
         * configure.ac: Fix spelling in comments.
         * configure: Regenerate.
 
diff --git a/gdb/contrib/expect-read1.sh b/gdb/contrib/expect-read1.sh
old mode 100644
new mode 100755
index cc9d811..5eec0dd
--- a/gdb/contrib/expect-read1.sh
+++ b/gdb/contrib/expect-read1.sh
@@ -15,7 +15,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-# This tool excercise any incomplete reads handling in the testsuite by
+# This tool exercises any incomplete reads handling in the testsuite by
 # simulating read always returns just 1 character.
 # Testsuite incompatibilities are tracked as GDB PR testsuite/12649.
 
diff --git a/gdb/gdb_buildall.sh b/gdb/gdb_buildall.sh
index 1fc7b38..ed3ffb5 100644
--- a/gdb/gdb_buildall.sh
+++ b/gdb/gdb_buildall.sh
@@ -103,7 +103,7 @@ builddir=`cd $2 && /bin/pwd` || exit 1
 make=${MAKE:-make}
 MAKE=${make}
 export MAKE
-# We dont want GDB do dump cores.
+# We don't want GDB do dump cores.
 ulimit -c 0
 
 # Just make sure we're in the right directory.
diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
index 08927f1..da0c19a 100755
--- a/gdb/gdb_mbuild.sh
+++ b/gdb/gdb_mbuild.sh
@@ -195,7 +195,7 @@ log ()
 
 
 
-# Warn the user of what is comming, print the list of targets
+# Warn the user of what is coming, print the list of targets
 
 echo "$alltarg"
 echo ""
@@ -273,7 +273,7 @@ do
     then
 	# Iff the build fails remove the final build target so that
 	# the follow-on code knows things failed.  Stops the follow-on
-	# code thinking that a failed rebuild succedded (executable
+	# code thinking that a failed rebuild succeeded (executable
 	# left around from previous build).
 	echo ... ${make} ${keepgoing} ${makejobs} ${target}
 	( ${make} ${keepgoing} ${makejobs} all-gdb || rm -f gdb/gdb gdb/gdb.exe
-- 
2.5.5



-- 
Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]