This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Fix copy_bitwise()

On 11/24/2016 04:15 PM, Andreas Arnez wrote:

> Hm, I'm not quite convinced.  Fooling the test with a broken algorithm
> is probably easier with regular test patterns than with pseudo-random
> ones.  For instance, consider an implementation that does not advance
> the byte position in the source buffer at all.

Agreed.

> 
> I do understand your concern about being "deterministic", though.  Thus
> I've taken another shot, see the patch below.

Perfect!

Please push.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]