This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Adjust Value.location for lval_register
On Fri, Nov 25, 2016 at 12:51:30PM +0100, Ulrich Weigand wrote:
>
>
> > /* Describes offset of a value within lval of a structure in target
> > addressable memory units. If lval == lval_memory, this is an offset to
> > - the address. If lval == lval_register, this is a further offset from
> > - location.address within the registers structure. Note also the member
> > - embedded_offset below. */
> > + the address. Note also the member embedded_offset below. */
> > LONGEST offset;
>
> Hmm, I think we recently had the discussion that *any* values should allow
> using an offset. The comment should probably reflect this.
>
How about "Describes offset of a value within lval of a structure. Note
also the member embedded_offset below."?
--
Yao (齐尧)