This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Adjust Value.location for lval_register


> On Fri, Nov 25, 2016 at 12:51:30PM +0100, Ulrich Weigand wrote:
> > 
> > 
> > >    /* Describes offset of a value within lval of a structure in target
> > >       addressable memory units.  If lval == lval_memory, this is an offset to
> > > -     the address.  If lval == lval_register, this is a further offset from
> > > -     location.address within the registers structure.  Note also the member
> > > -     embedded_offset below.  */
> > > +     the address.  Note also the member embedded_offset below.  */
> > >    LONGEST offset;
> > 
> > Hmm, I think we recently had the discussion that *any* values should allow
> > using an offset.  The comment should probably reflect this.
> > 
> 
> How about "Describes offset of a value within lval of a structure.  Note 
> also the member embedded_offset below."?

I think we should leave in the "in target addressable memory units" to clarify
that this is a *byte* offset, not a bit offset.

Otherwise, looks good to me.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]