This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Adjust Value.location for lval_register
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: qiyaoltc at gmail dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 25 Nov 2016 13:10:02 +0100 (CET)
- Subject: Re: [PATCH 2/3] Adjust Value.location for lval_register
- Authentication-results: sourceware.org; auth=none
> On Fri, Nov 25, 2016 at 12:51:30PM +0100, Ulrich Weigand wrote:
> >
> >
> > > /* Describes offset of a value within lval of a structure in target
> > > addressable memory units. If lval == lval_memory, this is an offset to
> > > - the address. If lval == lval_register, this is a further offset from
> > > - location.address within the registers structure. Note also the member
> > > - embedded_offset below. */
> > > + the address. Note also the member embedded_offset below. */
> > > LONGEST offset;
> >
> > Hmm, I think we recently had the discussion that *any* values should allow
> > using an offset. The comment should probably reflect this.
> >
>
> How about "Describes offset of a value within lval of a structure. Note
> also the member embedded_offset below."?
I think we should leave in the "in target addressable memory units" to clarify
that this is a *byte* offset, not a bit offset.
Otherwise, looks good to me.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com