Re: [PATCH 1/8] Fixup testcases outputting own name as a test name

[Pedro Alves <palves at redhat dot com>]

On 11/25/2016 06:26 PM, Luis Machado wrote:
> On 11/25/2016 12:02 PM, Simon Marchi wrote:
>> On 2016-11-25 12:55, Pedro Alves wrote:
>>> Or just not pass anything about the target file?
>>> "failed to compile" works just as well, IMO.  If you need more detail,
>>> it's in the gdb.log.
>>
>> Agreed, I think that's even better.  I was first thinking it would be
>> useful to have the dest file, in the cases where the same source file is
>> compiled multiple times to multiple destinations.  But you're right that
>> if you want details, you'll go look at gdb.log.  It's enough for the
>> test name to give a rough idea of what failed.
> 
> Great. I'll adjust things.
> 
> Should i get the existing tests that already output srcfile paths on
> compilation failures fixed up and standardized with this patch as well
> or with a separate one?

IMO, whatever you prefer.  There's no harm in doing it incrementally.

It'd make a difference if the previous version of the patch was mostly
OK except some detail that only mattered in a few hunks.  Bundling
everything would force reviewers to waste time rereading what was already
OKed.  In such a case, I'd rather the OKed parts were pushed in and the
NAKed parts to be left for a separate follow up patch.
But in this patch's case, you'll end up retouching most hunks anyway.

Thanks,
Pedro Alves