This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 20/22] Class-ify ui_out_table


On 11/26/2016 05:18 PM, Simon Marchi wrote:
> On 2016-11-24 10:32, Simon Marchi wrote:
>> +  /* States (steps) of a table generation.  */
>> +
>> +  enum state
>> +  {
>> +    /* We are generating the table headers.  */
>> +    TABLE_STATE_HEADERS,
>> +
>> +    /* We are generating the table body.  */
>> +    TABLE_STATE_BODY,
>> +  };
> 
> I changed the enum to:
> 
>   /* States (steps) of a table generation.  */
> 
>   enum class state
>   {
>     /* We are generating the table headers.  */
>     HEADERS,
> 
>     /* We are generating the table body.  */
>     BODY,
>   };
> 
> and adjusted the references.

I looked at your branch to see the end result, and it
looks good to me.  But please post the final result for
the archives.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]