This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Remove make_cleanup_htab_delete

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 30 Nov 2016 09:04:56 -0700
Subject: Re: [RFA] Remove make_cleanup_htab_delete
Authentication-results: sourceware.org; auth=none
References: <1479674269-13540-1-git-send-email-tom@tromey.com> <6f071b3d-ce3a-2090-cc19-12ebec6bcb57@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 11/20/2016 08:37 PM, Tom Tromey wrote:
>> This removes make_cleanup_htab_delete in favor of destructors,
>> building on an earlier patch that added the htab_up typedef.

Pedro> We could probably convert all of these to std::unordered_map,
Pedro> but meanwhile ...

It turns out that parts of this patch were incorrect.
In particular, some of the htabs were allocated on obstacks, and so
changing these to htab_up caused a use-after-free due to changing the
ordering of the obstack and htab destruction.

I have a new patch that fixes this by going a bit further and changing
these htabs to unordered_set.  I'll send it a bit later.

Tom

References:
- [RFA] Remove make_cleanup_htab_delete
  - From: Tom Tromey
- Re: [RFA] Remove make_cleanup_htab_delete
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]