This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Change return type of ui_out redirect to void
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, Luis Machado <lgustavo at codesourcery dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 Jan 2017 15:50:42 +0000
- Subject: Re: [PATCH] Change return type of ui_out redirect to void
- Authentication-results: sourceware.org; auth=none
- References: <20161222220728.15146-1-simon.marchi@ericsson.com> <81609b60-0821-3f1b-7613-5bf691727d5f@codesourcery.com> <4270f5e03af2b1e554fc4ddaf1a0a8c7@polymtl.ca>
On 01/03/2017 04:17 PM, Simon Marchi wrote:
> Right, now that I re-read it, it does sound funny. Fixed locally to:
>
> /* There is a former output pushed on the ui_out_redirect stack. We
> want to replace it by OUTPUT so we must pop the former value
> - first. We should either do both the pop and push or to do
> - neither of it. At least do not try to push OUTPUT if the pop
> - already failed. */
> + first. Ideally, we should either do both the pop and push or do
> + neither of them. */
>
> Thanks!
OK with that change.
BTW, also spotted a spurious whitespace after "*" here:
> @@ -163,7 +163,7 @@ class ui_out
> ATTRIBUTE_PRINTF (2,0) = 0;
> virtual void do_wrap_hint (const char *identstring) = 0;
> virtual void do_flush () = 0;
> - virtual int do_redirect (struct ui_file * outstream) = 0;
> + virtual void do_redirect (struct ui_file * outstream) = 0;
Thanks,
Pedro Alves