This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 2/2] btrace: allow recording to be started for running threads

From: Pedro Alves <palves at redhat dot com>
To: Markus Metzger <markus dot t dot metzger at intel dot com>, gdb-patches at sourceware dot org
Cc: Simon Marchi <simon dot marchi at ericsson dot com>
Date: Wed, 25 Jan 2017 14:35:43 +0000
Subject: Re: [PATCH v2 2/2] btrace: allow recording to be started for running threads
Authentication-results: sourceware.org; auth=none
References: <1484923135-31270-1-git-send-email-markus.t.metzger@intel.com> <1484923135-31270-3-git-send-email-markus.t.metzger@intel.com> <e7a77d2d-b15f-152e-bbc2-81296b6ef101@redhat.com>

On 01/25/2017 02:32 PM, Pedro Alves wrote:

>> +# Check that recording was started on each thread.
>> +foreach thread {1 2 3 4} {
>> +    check_tracing_enabled $thread
> 
> Looks like this is adding duplicate test messages?  See:
> 
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique

Bah, somehow missed the with_test_prefix inside the proc.  Ignore
this remark.

Thanks,
Pedro Alves

References:
- [PATCH v2 0/2] thread, btrace: allow "record btrace" for running threads
  - From: Markus Metzger
- [PATCH v2 2/2] btrace: allow recording to be started for running threads
  - From: Markus Metzger
- Re: [PATCH v2 2/2] btrace: allow recording to be started for running threads
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]