This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64


On Thu, Jan 26, 2017 at 3:23 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>
> The patch is good to me, some nits below,
>
>> gdb/ChangeLog:
>>
>> 2016-12-19  Kees Cook  <keescook@google.com>
>>
>>     * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
>
> * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
> if target has fpa registers.
> (arm_linux_store_inferior_registers): Call store_fpregs if target has
> fpa registers.

Ah-ha, thanks!

>
>>      }
>> -  else
>> +  else
>>      {
>
> Unnecessary change.  I'll push your patch in tomorrow.

Okay, I wasn't sure if whitespace/code-style fixes should be merged as
they were found.

Thanks!

-Kees

-- 
Kees Cook
Nexus Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]