This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- From: Matt Rice <ratmice at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, Trevor Saunders <tbsaunde at tbsaunde dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 8 Feb 2017 20:34:20 -0800
- Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- Authentication-results: sourceware.org; auth=none
- References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> <c0a70339-49c3-a087-bebf-ecfdd2cc32ca@redhat.com> <87inok708e.fsf@tromey.com> <ab4096f6-6f76-2267-839b-4790e4abb49d@redhat.com>
On Wed, Feb 8, 2017 at 3:51 PM, Pedro Alves <palves@redhat.com> wrote:
>> Pedro> Patch LGTM with Trevor's and Simon's nits addressed.
>>
>> I have that done locally, but I've just been waiting until your series
>> lands, so I can rebase. And then maybe the option stuff wouldn't be
>> needed anyway? I don't remember the details from your branch, I was
>> just waiting for the big rebase to find out.
>
> My series is all in master. I think we'll still need your patch, since I only
> touched ui_files. I haven't done anything with ui_out list/tuple building.
I haven't been following much lately due to programming mostly in
languages unsupported by gdb apologies if this has been hashed out
before.
Wondering if this would be a good opportunity to try and transition
ui_out_list construction into a more type safe manner, e.g.
result ==> variable "=" value
list ==> "[]" | "[" value ( "," value )* "]" | "[" result ( "," result )* "]"
currently when building a list, it didn't specify whether you were
declaring a list of results or a list of values, unless/until the
first value or result was added, and IIRC this | property wasn't
really explicitly enforced.
it'd be nice to migrate this to something like:
result_list, value_list, deprecated_unspecified_list, It would be nice
to know if/when you guys think it would be a convenient time to
introduce such a change so I could get back up to speed...