This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/5] Introduce gdbpy_subclass and use it to simplify some logic
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 9 Feb 2017 13:00:07 +0000
- Subject: Re: [RFA 3/5] Introduce gdbpy_subclass and use it to simplify some logic
- Authentication-results: sourceware.org; auth=none
- References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-4-tom@tromey.com>
On 01/15/2017 01:42 PM, Tom Tromey wrote:
> diff --git a/gdb/python/py-ref.h b/gdb/python/py-ref.h
> index b2479bf..3430768 100644
> --- a/gdb/python/py-ref.h
> +++ b/gdb/python/py-ref.h
> @@ -1,6 +1,6 @@
> /* Python reference-holding class
>
> - Copyright (C) 2016 Free Software Foundation, Inc.
> + Copyright (C) 2016, 2017 Free Software Foundation, Inc.
No sure the end-year script converts this to a range automatically.
Better write 2016-2017 from the get go.
> /* A gdb::ref_ptr that has been specialized for Python objects. */
> -typedef gdb::ref_ptr<PyObject, gdbpy_ref_policy> gdbpy_ref;
> +typedef gdb::ref_ptr<PyObject, gdbpy_ref_policy<PyObject> > gdbpy_ref;
No need for the space in "> >" in C++11.
Other than the naming issue, this looks really nice to me.
Thanks,
Pedro Alves