This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA v2 0/7] more cleanup removal in Python
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 9 Feb 2017 14:24:49 -0700
- Subject: [RFA v2 0/7] more cleanup removal in Python
- Authentication-results: sourceware.org; auth=none
This is version 2 of my cleanup removal patch for the Python code.
Version 1 is here:
https://sourceware.org/ml/gdb-patches/2017-01/msg00279.html
I think this version addresses all the review comments; but there are
some other changes from v1:
* As discussed, use gdbpy_ref<> to wrap PyObject*; the old
"gdbpy_subclass" is now just a different instantiation of gdbpy_ref.
The initial work for this is done in a new patch (patch #2 in this
series), for clarity.
* Drop the ui_file_up patch, as this was done in a better way by
Pedro.
* Add a couple of obvious patches for issues I found while working on
this again: remove a couple of unused local variables, and fix a
couple of Python test cases.
* Fix one instance of the "declare gdbpy_ref object before a
gdbpy_enter object" bug that I found while re-reviewing the patch in
this series that adds some gdbpy_ref uses.
I built and tested the series locally; but I'm also running it through
the buildbot.
Let me know what you think.
Tom