This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support
- From: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>, lgustavo at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 21 Feb 2017 11:46:21 -0300
- Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support
- Authentication-results: sourceware.org; auth=none
- References: <20170221105525.933CED8313F@oc3748833570.ibm.com>
On 02/21/2017 07:55 AM, Ulrich Weigand wrote:
> Luis Machado wrote:
>> On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote:
>>> What about gdb.arch/ppc64-isa207-atomic-inst.*?
>>>
>>
>> Could be. I don't have a better suggestion. Maybe Ulrich has.
>
> Not really ... the name looks good to me.
>
>>> +if {![istarget "powerpc*"] || ![is_lp64_target]} {
>>> + verbose "Skipping testing of powerpc64 single stepping over atomic sequences."
>>
>> untested "skipping powerpc isa 207 atomic sequences test"?
>
> Agreed, makes sense.
>
>> Otherwise i have no further comments.
>
> Thanks for the review, Luis!
>
> Edjunior, the patch is OK with the above change.
>
> Thanks,
> Ulrich
>
Thank you folks for the review! Just checked in with the change Luis suggested:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2039d74e780db6659c87cd3c426d526615cfe703
--
Edjunior