This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h


On 02/28/2017 06:50 AM, Philipp Rudo wrote:
> this series cleans up several hooks in defs.h which were deprecated in 2004
> (9a4105ab).  Most of these hooks are no longer used and can be removed without
> problem.

As Tom and Simon have already mentioned, Insight still uses many (all?)
of these. [Don't laugh -- I still use Insight almost daily. I know, too,
that I am not alone.]

However, I don't think this patch should be dismissed solely because
Insight still uses them. [Insight was "kicked out" of the official GDB
repository several years ago.]

Instead, I would like to ask maintainers to consider that the "true"
deprecation of these hooks be phased in over a release or three to give
time to either replace them or assess how much time may be needed to
properly replace these hooks.

Keith

For the record, hooks currently used by Insight:

deprecated_ui_loop_hook
deprecated_call_command_hook
deprecated_readline_begin_hook
deprecated_readline_hook
deprecated_readline_end_hook
deprecated_print_frame_info_listing_hook
deprecated_query_hook
deprecated_warning_hook
deprecated_interactive_hook
deprecated_target_wait_hook
deprecated_ui_load_progress_hook
deprecated_ui_loop_hook
deprecated_pre_add_symbol_hook
deprecated_post_add_symbol_hook
deprecated_file_changed_hook
deprecated_attach_hook
deprecated_detach_hook
deprecated_context_hook
deprecated_error_begin_hook
deprecated_annotate_signal_hook
deprecated_annotate_signalled_hook
deprecated_warning_hook


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]