This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Luis Machado <lgustavo at codesourcery dot com>
- Date: Mon, 13 Mar 2017 15:12:42 +0000
- Subject: Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170208032257.15443-1-sergiodj@redhat.com> <20170208032257.15443-7-sergiodj@redhat.com> <a18a77b1-85a6-b963-172c-e3b9bb5fd5d6@redhat.com> <87zigwerc0.fsf@redhat.com>
On 03/07/2017 08:59 PM, Sergio Durigan Junior wrote:
>> Note, you'll need NEWS entries for the new remote protocol packets too.
>
> I've added a NEWS entry for QStartupWithShell under the "New remote
> packets" section. Do you want me to add another entry somewhere else?
>
Not offhand. I'll take a look at v4.
>> Can you explain the rationale for doing this here? What about:
>>
>> (gdb) target extended-remote ....
>> (gdb) set startup-with-shell off
>> (gdb) run
>>
>> ?
>
> Hm, I guess it just seemed like a good place to initialize the packet.
> But you're right, this won't work if the user sets the
> startup-with-shell parameter *after* connecting to the target. So I'll
> move this code to the extended_remote_create_inferior function, if
> that's alright.
Yes, that sounds like the right place. This is quite similar to
disabling address space randomization, and we do that in
extended_remote_create_inferior too.
Thanks,
Pedro Alves