This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdbserver: Suffix generated C files with -generated
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Fri, 31 Mar 2017 16:12:57 +0100
- Subject: Re: [PATCH v2] gdbserver: Suffix generated C files with -generated
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 99853C05AA56
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99853C05AA56
- References: <f2389355-1418-eed4-5a82-248448cad755@redhat.com> <20170331145554.26349-1-simon.marchi@ericsson.com>
On 03/31/2017 03:55 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> I noticed that there were some missing files in gdbserver's gitignore
> (some generated register format .c files). Of course the easy fix would
> be to add those files to .gitignore, but I think we can do a better job,
> so that we don't have to worry about adding generated files to
> .gitignore or the clean Makefile target.
>
> I suggest naming all generated source files -generated.c. This way, we
> can use a single rule in .gitignore and do a "rm -f *-generated.c" to
> clean them up.
>
> New in v2:
>
> - Don't rename version.o and xml-builtin.o
>
> gdb/gdbserver/ChangeLog:
>
> * .gitignore: Remove generated files, replace with wildcard.
> * (clean): Replace removal of generated files with wildcard.
> (version.c): Replace with...
> (version-generated.c): ...this.
> (xml-builtin.c): Replace with...
> (xml-builtin-generated.c): ...this.
> (%-ipa.o: %-generated.c, %.o: %-generated.c): New rules.
> (%.c: *regformats*): Replace with...
> (%-generated.c: *regformats*): ...this.
OK.
Thanks,
Pedro Alves