This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Class-ify ptid_t

On 04/06/2017 11:49 AM, Pedro Alves wrote:
> Yes, I think we should put that in the unit test with a comment

Or leave it in ptid.c, doesn't have to be in a separate file.
Putting it in the .c file instead of the .h has the advantage
that it doesn't expose type_traits.h to all of gdb, that's all.
(Though I'm not sure whether be able to avoid it as we grow more
C++ utilities.)

> so that if someone tries to add something that would make it
> non-pod, gdb won't even compile.  If/when we get to the point where
> we can/want to make it non-pod, we can remove the assertion then.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]