This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Oh dear. I regret to inform you that commit 'ELF: Check ELF_COMMON_DEF_P for common symbols' might be unfortunate
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Fri, 7 Apr 2017 16:32:36 +0100
- Subject: Re: Oh dear. I regret to inform you that commit 'ELF: Check ELF_COMMON_DEF_P for common symbols' might be unfortunate
- Authentication-results: sourceware.org; auth=none
- References: <E1cwVGv-0000oa-E4@kwanyin.sergiodj.net> <CAMe9rOoypJM6go1KhrOcdBdf7=XtZShoo3t7xKh2vT0ODTdbpg@mail.gmail.com>
On Fri, Apr 7, 2017 at 4:03 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Could someone please fix this? The problem is
>
> ../../binutils-gdb/opcodes/wasm32-dis.c:408:34: error: ‘DECIMAL_DIG’
> undeclared (first use in this function)
> prin (stream, " %.*g", DECIMAL_DIG, fconstant);
> ^
> ../../binutils-gdb/opcodes/wasm32-dis.c:408:34: note: each undeclared
> identifier is reported only once for each function it appears in
> make[4]: *** [wasm32-dis.lo] Error 1
> make[4]: *** Waiting for unfinished jobs....
>
> which has nothing to do with my commit.
>
The patch is being reviewed,
https://sourceware.org/ml/binutils/2017-04/msg00066.html
--
Yao (齐尧)